-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
By default enable HIBP check #148
Conversation
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
I think we can do this but we should also check for password_policy/lib/Validator/HIBPValidator.php Lines 63 to 76 in 37b2f4e
|
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Actually I moved this a directly into the config check, this also makes it more obvious for admins in the UI that somehow HIBP is not enabled :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reasonable for 22
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Okay - this is somehow merged into master but not marked in this PR: f356c91 |
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl