-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Implement date sorting in timeline #125
Conversation
@jancborchardt Need your input for the expected design |
Super awesome!! Very great job @Mikescops 🚀 🤗 |
wow! Awesome work! |
Aaaaawesome! :) Some feedback as said:
|
@skjnldsv i completely changed the way we load element because it was a source a confusion and could break at any time because it was empirical way of counting the height of the elements within the grid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skjnldsv i completely changed the way we load element because it was a source a confusion and could break at any time because it was empirical way of counting the height of the elements within the grid.
So you just removed the entire virtual scroller implementation ?
This is a no go for me. Open the timeline with 100k images and see your browser crash :)
@skjnldsv how this could crash? This version is even more efficient in term of memory.. |
I think i understand now what you did, but we should improve it, or do it differently |
So what are the next steps here @skjnldsv @Mikescops? :)
That’s a separate issue from this pull request :) see discussion and options at #145 (TL;DR let’s first go with this view that e.g. iOS and Android Photos as well as Instagram use.) |
I think Corentin was more refering of the technical css grid implementation :) |
Yes |
Signed-off-by: Corentin Mors <corentin.mors@dashlane.com>
5c9b9a6
to
a1bc036
Compare
Spent 4hours on it and i can't find a way to do it properly without changing the whole grid system. |
This write-up about the Google Photos Web UI and how they achieve their photo placement might be helpful, as they tackled the same problem and solved it pretty well I would say. |
Especially this part: https://medium.com/google-design/google-photos-45b714dfbed1#247b
Same as we do, conceptually at least :) I'll read about it more in details, I gave a few quick looks at this article before, and need to find the time to dive into it a bit further! |
I think the way we get the image list can be sort of blocker, because it's not so flexible |
How so? What do you have in mind? :) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Any new as the the issue is closed? |
I guess we'll either have to rely on another lib or fix our own implementation :( I found one react implementation that works super well! https://github.com/jamiebuilds/react-gridlist |
Shall we recode it for Vue? |
Feel free to do so. Such lib would most likely gain lots of interest as there is none! :) |
😅 yeah sure 😅 |
hope this server features can help you : #466 |
FYI, I did the lib, should be soon integrated 😅 https://www.npmjs.com/package/vue-virtual-grid |
you're a champion! 🦸 |
This has been reworked in #468 I'm closing this PR as it is obsolete. |
This is a first draft for the timeline date separator.
fix #45