Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listen to more events for albums #1337

Merged
merged 3 commits into from
May 9, 2023
Merged

Listen to more events for albums #1337

merged 3 commits into from
May 9, 2023

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Oct 13, 2022 •
edited
Loading

Add handling for UserDeletedEvent and ShareDeletedEvent

Any other event we should listen too ?

@artonge artonge added enhancement New feature or request 3. to review Waiting for reviews php PHP related ticket feature: albums Related to the albums section labels Oct 13, 2022
@artonge artonge added this to the Nextcloud 26 milestone Oct 13, 2022
@artonge artonge requested a review from skjnldsv October 13, 2022 14:28
@artonge artonge self-assigned this Oct 13, 2022
@artonge
Copy link
Collaborator Author

artonge commented Oct 13, 2022

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Oct 13, 2022
artonge
artonge commented Oct 13, 2022
View reviewed changes
lib/Listener/AlbumsManagementFileEventListener.php Outdated Show resolved Hide resolved
lib/Album/AlbumMapper.php Outdated Show resolved Hide resolved
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@artonge artonge force-pushed the artonge/feat/listen_to_more_event_for_albums branch from 0330548 to f5ddfa8 Compare February 2, 2023 17:02
@simonspa
Copy link

simonspa commented Feb 9, 2023

@artonge I think this is useful and will make the response to system changes more complete. However, I think this needs a rebase because of the additional events added in #1601 and the change to the cache listener event in #1598

@artonge artonge force-pushed the artonge/feat/listen_to_more_event_for_albums branch from f5ddfa8 to 18e55f9 Compare February 9, 2023 10:33
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@skjnldsv skjnldsv mentioned this pull request May 3, 2023
Merged
@artonge artonge force-pushed the artonge/feat/listen_to_more_event_for_albums branch from 0fa449a to 1802ead Compare May 6, 2023 16:42
This was referenced May 9, 2023
Closed
Merged
come-nc
come-nc reviewed May 9, 2023
View reviewed changes
lib/Listener/AlbumsManagementEventListener.php Outdated
Comment on lines 68 to 70
}

if ($event instanceof GroupDeletedEvent) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
if ($event instanceof GroupDeletedEvent) {
} elseif ($event instanceof GroupDeletedEvent) {

And the other ones?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other kind of events? They are above

@artonge
Listen to more events for albums
7321935 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Merge listeners related to albums
b855b5c 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Log silenced exception and use elseif
70e719b 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/feat/listen_to_more_event_for_albums branch from d2b6315 to 70e719b Compare May 9, 2023 15:34
@artonge artonge enabled auto-merge May 9, 2023 15:45
@artonge artonge merged commit bf88722 into master May 9, 2023
@artonge artonge deleted the artonge/feat/listen_to_more_event_for_albums branch May 9, 2023 21:02
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 9, 2023
Merged
1 task
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label May 9, 2023
@skjnldsv skjnldsv mentioned this pull request May 10, 2023
Merged
15 tasks
@artonge
Copy link
Collaborator Author

artonge commented Jun 5, 2023

/backport to stable26

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Jun 5, 2023
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 5, 2023
Merged
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonspa simonspa simonspa left review comments

@come-nc come-nc come-nc left review comments

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews enhancement New feature or request feature: albums Related to the albums section php PHP related ticket
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
5 participants
@artonge @simonspa @skjnldsv @come-nc @blizzz