Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-cropped layout #435

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Non-cropped layout #435

merged 1 commit into from
Oct 16, 2020

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 1, 2020 •
edited
Loading

Capture d’écran_2020-09-01_11-03-12

Fix #143

@skjnldsv skjnldsv self-assigned this Sep 1, 2020
@skjnldsv skjnldsv added 2. developing Work in progress design Related to the design enhancement New feature or request labels Sep 1, 2020
@Mikescops Mikescops self-assigned this Oct 15, 2020
@Mikescops Mikescops added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 15, 2020
@Mikescops
Copy link
Member

@jancborchardt @skjnldsv good to go

@skjnldsv
Copy link
Member Author

/compile amend /

@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 16, 2020 •
edited
Loading

Can't approve my own pr, but looks good 👍 :)

Just rebase and squash! 🚀

Mikescops
Mikescops approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@Mikescops Mikescops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can approve my half PR

@Mikescops
Copy link
Member

/compile amend /

@skjnldsv @npmbuildbot
Non-cropped layout
f612c26 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@Mikescops Mikescops merged commit 4de71e5 into master Oct 16, 2020
@Mikescops Mikescops deleted the enh/non-cropping branch October 16, 2020 07:11
@jancborchardt jancborchardt mentioned this pull request Oct 16, 2020
Closed
@grenzverkehr grenzverkehr mentioned this pull request Oct 17, 2020
Closed
@skjnldsv skjnldsv mentioned this pull request Nov 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikescops Mikescops Mikescops approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

@Mikescops Mikescops

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews design Related to the design enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No cropping photo design
2 participants
@skjnldsv @Mikescops