-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Regression Fix] Readd timeline caching #478
Conversation
Signed-off-by: Corentin Mors <corentin.mors@dashlane.com>
Signed-off-by: Corentin Mors <corentin.mors@dashlane.com>
@skjnldsv done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny change, all good code-wise :)
One question though, why use Promise.resolve ?
Returning should be enough in those cases,
The lib expect a Promise so that it can do other actions in the meantime. |
Signed-off-by: Corentin Mors <corentin.mors@dashlane.com>
Signed-off-by: Corentin Mors <corentin.mors@dashlane.com>
b4a40dc
to
753447b
Compare
The async function resolves themselves with return or throw. |
This returns a promise:
|
hmmm I need to better look at it |
Fixing a regression following #468 after update of the vue-virtual-grid package.
The caching of the timeline is now used again. It helped simplifying some part of the logic too.