Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to new nextcloud npm packages #273

Merged
merged 2 commits into from
Apr 20, 2020
Merged

Conversation

georgehrke
Copy link
Member

@georgehrke georgehrke commented Nov 27, 2019

fixes #244

What this pull-request does:

  • move from old nextcloud-* packages to @nextcloud/*
  • move from Promises to async / await
  • move from using data attributes to InitialStateService
  • ...

@georgehrke georgehrke force-pushed the bugfix/noid/new_packages branch 5 times, most recently from 856559f to 2a2f88c Compare November 28, 2019 14:00
Copy link
Member

@gary-kim gary-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you're still working on this but I noticed a few things. Hope you don't mind 😄

package.json Outdated Show resolved Hide resolved
src/main.js Show resolved Hide resolved
webpack.common.js Outdated Show resolved Hide resolved
@skjnldsv
Copy link
Member

skjnldsv commented Apr 6, 2020

Bump!

@georgehrke
Copy link
Member Author

Bump!

Yes, it's on my todo list for this week, so we can have this in 19

@skjnldsv
Copy link
Member

skjnldsv commented Apr 6, 2020

Yes, it's on my todo list for this week, so we can have this in 19

ahah, sorry, I was looking for apps that uses nextcloud-vue still 🙈

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the bugfix/noid/new_packages branch 2 times, most recently from 3745be4 to ec9eb4b Compare April 17, 2020 08:28
package.json Outdated Show resolved Hide resolved
@@ -1,55 +1,55 @@
const path = require('path')
const StyleLintPlugin = require('stylelint-webpack-plugin')
const { VueLoaderPlugin } = require('vue-loader')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the kind of apps for which a standard webpack config would works flawlessly too!
@ChristophWurst skjnldsv/vueexample#238

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copy and pasted it from the app-tutorial ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :)
I mean, we discussed it last week on the js channel, about a nice vue webpack library which we can easily use in our apps and extend!
Christoph was doubting it, but we have tons of apps who have pretty much all the same webpack files and would benefit from just relying on an external template I think!

What do you think @georgehrke ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally in favour of everything that makes things easier for standard apps. It should work for most apps (mostly excluding those which rely on async imports for moment locales).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to deploy this and integrate it in other places!

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke merged commit eef7e06 into master Apr 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/new_packages branch April 20, 2020 10:42
@rullzer rullzer mentioned this pull request Apr 21, 2020
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use shared browserslist config
4 participants