-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable27] Revert "perf(dashboard): implement widget item api v2" #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
approved these changes
Oct 30, 2023
Pytal
approved these changes
Oct 30, 2023
some tests are failing and also requires a rebuild |
moving to 27.1.5 |
/compile / |
@st3iny conflicts |
moving to 27.1.6 |
@Pytal @ChristophWurst what to do about this PR? |
Not sure as the original PR has not been merged either #667, would say @st3iny knows best :) |
This reverts commit f890baf. Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
revert/644-stable27
branch
from
January 17, 2024 09:56
053e1b1
to
ebdbc7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to close if this backport is not required.
Manual backport of #667
This reverts commit f890baf.
I tested this locally and the dashboard widgets works like it did before (builtin viewer etc.).