Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mobile support shall be enabled by default #3184

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Sep 17, 2023

Seems we broke the default with #3141

Now it compares against the default of 'yes' which does not evaluate to false by default.

To disable one can use:

occ config:app:set richdocuments mobile_editing --value="no"

@juliusknorr
Copy link
Member Author

/backport to stable27

@juliusknorr
Copy link
Member Author

/backport to stable26

@juliusknorr
Copy link
Member Author

/backport to stable25

@juliusknorr
Copy link
Member Author

/backport to stable24

@juliusknorr
Copy link
Member Author

/backport to stable4

@juliusknorr juliusknorr added 3. to review Ready to be reviewed regression labels Sep 17, 2023
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@cypress
Copy link

cypress bot commented Sep 17, 2023

Passing run #624 ↗︎

0 27 5 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

fix: Mobile support shall be enabled by default
Project: Richdocuments Commit: 6e0d46bdf7
Status: Passed Duration: 05:17 💡
Started: Sep 17, 2023 3:50 PM Ended: Sep 17, 2023 3:56 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good.

@max-nextcloud max-nextcloud merged commit 731c482 into main Sep 17, 2023
41 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/mobile-support branch September 17, 2023 20:30
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable24
git pull origin stable24

# Create the new backport branch
git checkout -b fix/foo-stable24

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable24

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable4 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable4
git pull origin stable4

# Create the new backport branch
git checkout -b fix/foo-stable4

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable4

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@Alternativend
Copy link

Is this the reason why office documents on Android are not working?
iOS and Browser are fine here, but all Androids are broken.

@jakobroehrl
Copy link

Is this the reason why office documents on Android are not working? iOS and Browser are fine here, but all Androids are broken.

#3141 (comment)

@szaimen
Copy link
Contributor

szaimen commented Sep 26, 2023

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@szaimen szaimen restored the bugfix/noid/mobile-support branch September 26, 2023 08:56
@szaimen szaimen deleted the bugfix/noid/mobile-support branch September 26, 2023 09:01
@szaimen
Copy link
Contributor

szaimen commented Sep 26, 2023

#3200

@juliusknorr
Copy link
Member Author

#3220
#3221
#3222
#3223

@Alternativend
Copy link

Still the same problems after updating Nextcloud Office to 8.2.1.

@raystek
Copy link

raystek commented Jan 6, 2024

The ios Nextcloud app works fine. It opens up the document for viewing/editing. The Android app just spins.

@max-nextcloud
Copy link
Contributor

@raystek could you open a new issue for this? Your comment might get lost here as the PR has already been merged.
Thanks!

@Keessaus
Copy link
Contributor

I am experiencing the same issues, but do not have much in terms of debugging data. If @raystek is still experiencing these issues, could you create an issue? If not, I would happily try to debug this if someone could point me to some Nextcloud Android app logs.

@Keessaus
Copy link
Contributor

For me, this seems to be related to a (closed) Android app issue: nextcloud/android#12338.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants