Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly provide instance id #3218

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Oct 10, 2023

Fix diverging sessions between logged in and public users

Fix #3187

Being used in the frontend at

fileId: fileid + '_' + loadState('richdocuments', 'instanceId', 'instanceid') + (version > 0 ? '_' + version : ''),

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug Something isn't working 3. to review Ready to be reviewed high labels Oct 10, 2023
@juliusknorr juliusknorr marked this pull request as ready for review October 10, 2023 11:24
@cypress
Copy link

cypress bot commented Oct 10, 2023

11 failed tests on run #653 ↗︎

11 11 5 5 Flakiness 0

Details:

fix: Properly provide instance id
Project: Richdocuments Commit: b6ac189db1
Status: Failed Duration: 05:56 💡
Started: Oct 10, 2023 11:41 AM Ended: Oct 10, 2023 11:46 AM
Failed  open.spec.js • 8 failed tests

View Output Video

Test Artifacts
Open existing office files > Classic UI: Open document.odt the viewer on file click Test Replay Output Screenshots
Open existing office files > Notebookbar UI: Open document.odt the viewer on file click Test Replay Output Screenshots
Open existing office files > Classic UI: Open presentation.odp the viewer on file click Test Replay Output Screenshots
Open existing office files > Notebookbar UI: Open presentation.odp the viewer on file click Test Replay Output Screenshots
Open existing office files > Classic UI: Open spreadsheet.ods the viewer on file click Test Replay Output Screenshots
Open existing office files > Notebookbar UI: Open spreadsheet.ods the viewer on file click Test Replay Output Screenshots
Open existing office files > Classic UI: Open drawing.odg the viewer on file click Test Replay Output Screenshots
Open existing office files > Notebookbar UI: Open drawing.odg the viewer on file click Test Replay Output Screenshots
Failed  share-internal.spec.js • 2 failed tests

View Output Video

Test Artifacts
File sharing of office documents > Open a shared file Test Replay Output Screenshots
File sharing of office documents > Open a shared file as readonly Test Replay Output Screenshots
Failed  integration.spec.js • 1 failed test

View Output Video

Test Artifacts
Nextcloud integration > Sharing sidebar Test Replay Output Screenshots

Review all test suite changes for PR #3218 ↗︎

@juliusknorr
Copy link
Member Author

Cypress failure is known due to upstream issue in server which breaks viewer

@juliusknorr juliusknorr merged commit 28d6a71 into main Oct 10, 2023
40 of 42 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/instance-id branch October 10, 2023 12:11
@juliusknorr
Copy link
Member Author

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File shared by link cannot be collaboratively edited
2 participants