fix: Apply viewer wrapper as we do it in text #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Knorr <jus@bitgrid.net>
|
/backport to stable30 |
|
/backport to stable29 |
elzody
approved these changes
Nov 29, 2024
This was referenced Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4259 to address the issues that come with different vue instances (nextcloud-libraries/nextcloud-vue#6280)
This PR introduces a similar pattern as we do it in text where we have a simple Viewer component that just wraps our main Office component. The main goal is to extend our main Office component from our own vue instance to avoid issues further down the compoent tree (e.g. when initializing NcTextField within a component that is rendered by spawnDialog).
Take it with care, it is mostly replicating what worked on text, but seems to work and not log errors in the console anymore.
Ideally viewer would not leak its vue instance in apps that register a handler nextcloud/viewer#2395 (comment)