-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
- Loading branch information
1 parent
aff189c
commit 0576f82
Showing
9 changed files
with
185 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,139 @@ | ||
<?php | ||
declare (strict_types = 1); | ||
/** | ||
* @copyright Copyright (c) 2018 Michael Weimann <mail@michael-weimann.eu> | ||
* | ||
* @author Michael Weimann <mail@michael-weimann.eu> | ||
* | ||
* @license GNU AGPL version 3 or any later version | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License as | ||
* published by the Free Software Foundation, either version 3 of the | ||
* License, or (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
* | ||
*/ | ||
|
||
namespace Tests\Core\Controller; | ||
|
||
use OC\AppFramework\Http; | ||
use OC\Core\Controller\SvgController; | ||
use OCP\App\IAppManager; | ||
use OCP\AppFramework\Utility\ITimeFactory; | ||
use OCP\IRequest; | ||
use Test\TestCase; | ||
|
||
/** | ||
* This class provides test cases for the svg controller | ||
*/ | ||
class SvgControllerTest extends TestCase { | ||
|
||
const TEST_IMAGES_SOURCE_PATH = __DIR__ . '/../../data/svg'; | ||
const TEST_IMAGES_PATH = __DIR__ . '/../../../core/img/testImages'; | ||
const TEST_IMAGE_MIXED = 'mixed-source.svg'; | ||
const TEST_IMAGE_RECT = 'rect-black.svg'; | ||
const TEST_IMAGES = [ | ||
self::TEST_IMAGE_MIXED, | ||
self::TEST_IMAGE_RECT, | ||
]; | ||
|
||
/** | ||
* @var SvgController | ||
*/ | ||
private $svgController; | ||
|
||
/** | ||
* Copy test svgs into the core img "test" directory. | ||
* | ||
* @beforeClass | ||
* @return void | ||
*/ | ||
public static function copyTestImagesIntoPlace() { | ||
mkdir(self::TEST_IMAGES_PATH); | ||
foreach (self::TEST_IMAGES as $testImage) { | ||
copy( | ||
self::TEST_IMAGES_SOURCE_PATH .'/' . $testImage, | ||
self::TEST_IMAGES_PATH . '/' . $testImage | ||
); | ||
} | ||
} | ||
|
||
/** | ||
* Removes the test svgs from the core img "test" directory. | ||
* | ||
* @afterClass | ||
* @return void | ||
*/ | ||
public static function removeTestImages() { | ||
foreach (self::TEST_IMAGES as $testImage) { | ||
unlink(self::TEST_IMAGES_PATH . '/' . $testImage); | ||
} | ||
rmdir(self::TEST_IMAGES_PATH); | ||
} | ||
|
||
/** | ||
* Setups a SVG controller instance for tests. | ||
* | ||
* @before | ||
* @return void | ||
*/ | ||
public function setupSvgController() { | ||
$request = $this->getMockBuilder(IRequest::class)->getMock(); | ||
$timeFactory = $this->getMockBuilder(ITimeFactory::class)->getMock(); | ||
$appManager = $this->getMockBuilder(IAppManager::class)->getMock(); | ||
$this->svgController = new SvgController('core', $request, $timeFactory, $appManager); | ||
} | ||
|
||
/** | ||
* Checks that requesting an unknown image results in a 404. | ||
* | ||
* @test | ||
* @return void | ||
*/ | ||
public function testGetSvgFromCoreNotFound() { | ||
$response = $this->svgController->getSvgFromCore('huhuu', '2342', '#ff0000'); | ||
self::assertEquals(Http::STATUS_NOT_FOUND, $response->getStatus()); | ||
} | ||
|
||
/** | ||
* Provides svg coloring test data. | ||
* | ||
* @return array | ||
*/ | ||
public function provideGetSvgFromCoreTestData(): array { | ||
return [ | ||
'mixed' => ['mixed-source', 'f00', file_get_contents(self::TEST_IMAGES_SOURCE_PATH . '/mixed-red.svg')], | ||
'black rect' => ['rect-black', 'f00', file_get_contents(self::TEST_IMAGES_SOURCE_PATH . '/rect-red.svg')], | ||
]; | ||
} | ||
|
||
/** | ||
* Tests that retrieving a colored SVG works. | ||
* | ||
* @test | ||
* @dataProvider provideGetSvgFromCoreTestData | ||
* @param string $name The requested svg name | ||
* @param string $color The requested color | ||
* @param string $expected The expected svg | ||
* @return void | ||
*/ | ||
public function testGetSvgFromCore(string $name, string $color, string $expected) { | ||
$response = $this->svgController->getSvgFromCore('testImages', $name, $color); | ||
|
||
self::assertEquals(Http::STATUS_OK, $response->getStatus()); | ||
|
||
$headers = $response->getHeaders(); | ||
self::assertArrayHasKey('Content-Type', $headers); | ||
self::assertEquals($headers['Content-Type'], 'image/svg+xml'); | ||
|
||
self::assertEquals($expected, $response->getData()); | ||
} | ||
} |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.