Skip to content

Commit

Permalink
improve notify tests for smb
Browse files Browse the repository at this point in the history
Signed-off-by: Robin Appelman <robin@icewind.nl>
  • Loading branch information
icewind1991 committed Jan 21, 2022
1 parent 31af141 commit 18a0e25
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions apps/files_external/tests/Storage/SmbTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ public function testNotifyGetChanges() {
];

foreach ($expected as $expectedChange) {
$this->assertContains($expectedChange, $changes, 'Actual changes are:' . PHP_EOL . print_r($expected, true), false, false); // dont check object identity
$this->assertContainsEquals($expectedChange, $changes, "Expected changes are:\n" . print_r($expected, true) . "\nGot:\n" . print_r($changes, true)); // dont check object identity
}
}

Expand All @@ -135,7 +135,7 @@ public function testNotifyListen() {

$result = null;

// since the notify handler buffers untill we start listening we will get the above changes
// since the notify handler buffers until we start listening we will get the above changes
$notifyHandler->listen(function (IChange $change) use (&$result) {
$result = $change;
return false;//stop listening
Expand Down

0 comments on commit 18a0e25

Please sign in to comment.