log failures to read certificates during listing

Signed-off-by: Robin Appelman <robin@icewind.nl>
nextcloud · Jun 12, 2023 · 1e0e526 · 1e0e526
1 parent 0ef6996
commit 1e0e526
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/lib/private/Security/CertificateManager.php b/lib/private/Security/CertificateManager.php
@@ -83,8 +83,14 @@ public function listCertificates(): array {
 		while (false !== ($file = readdir($handle))) {
 			if ($file != '.' && $file != '..') {
 				try {
-					$result[] = new Certificate($this->view->file_get_contents($path . $file), $file);
+					$content = $this->view->file_get_contents($path . $file);
+					if ($content !== false) {
+						$result[] = new Certificate($content, $file);
+					} else {
+						$this->logger->error("Failed to read certificate from $path");
+					}
 				} catch (\Exception $e) {
+					$this->logger->error("Failed to read certificate from $path", ['exception' => $e]);
 				}
 			}
 		}