Skip to content

Commit

Permalink
Merge pull request #37421 from nextcloud/fix/36916-The_list_of_contac…
Browse files Browse the repository at this point in the history
…ts_represents_a_list,_but_it_was_not_marked_as_such

Change contactsmenu structure to a list
  • Loading branch information
JuliaKirschenheuter authored Mar 27, 2023
2 parents 7803ba1 + db0670f commit 1e85cb1
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 7 deletions.
7 changes: 6 additions & 1 deletion core/src/OC/contactsmenu.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ const ContactsListView = View.extend({
/** @type {array} */
_subViews: [],

/** @type {string} */
tagName: 'ul',

/**
* @param {object} options
* @returns {undefined}
Expand All @@ -98,7 +101,6 @@ const ContactsListView = View.extend({
var self = this
self.$el.html('')
self._subViews = []

self._collection.forEach(function(contact) {
var item = new ContactsListItemView({
model: contact
Expand Down Expand Up @@ -134,6 +136,9 @@ const ContactsListItemView = View.extend({
/** @type {string} */
className: 'contact',

/** @type {string} */
tagName: 'li',

/** @type {undefined|function} */
_template: undefined,

Expand Down
4 changes: 2 additions & 2 deletions dist/core-login.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-login.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/core-main.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-main.js.map

Large diffs are not rendered by default.

0 comments on commit 1e85cb1

Please sign in to comment.