Skip to content

Commit

Permalink
Fix action share icon markup
Browse files Browse the repository at this point in the history
Expanded the empty span tag to resolve issue with wrong appending done
by either handlebars or jquery.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
  • Loading branch information
PVince81 committed Oct 27, 2021
1 parent fcf688c commit 30d72cb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion apps/files/js/templates.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ templates['file_action_trigger'] = template({"1":function(container,depth0,helpe

return " <span class=\"icon "
+ container.escapeExpression(((helper = (helper = lookupProperty(helpers,"iconClass") || (depth0 != null ? lookupProperty(depth0,"iconClass") : depth0)) != null ? helper : container.hooks.helperMissing),(typeof helper === "function" ? helper.call(depth0 != null ? depth0 : (container.nullContext || {}),{"name":"iconClass","hash":{},"data":data,"loc":{"start":{"line":6,"column":21},"end":{"line":6,"column":34}}}) : helper)))
+ "\" />\n";
+ "\"></span>\n";
},"6":function(container,depth0,helpers,partials,data) {
var helper, lookupProperty = container.lookupProperty || function(parent, propertyName) {
if (Object.prototype.hasOwnProperty.call(parent, propertyName)) {
Expand Down
2 changes: 1 addition & 1 deletion apps/files/js/templates/file_action_trigger.handlebars
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<img class="svg" alt="{{altText}}" src="{{icon}}" />
{{else}}
{{#if iconClass}}
<span class="icon {{iconClass}}" />
<span class="icon {{iconClass}}"></span>
{{/if}}
{{#unless hasDisplayName}}
<span class="hidden-visually">{{altText}}</span>
Expand Down

0 comments on commit 30d72cb

Please sign in to comment.