Merge pull request #17001 from nextcloud/fix/noid/addressbookchanges-…

…avatar reduce adressbook change events and handling
nextcloud · Oct 1, 2019 · 47ab961 · 47ab961
2 parents d68f30e + d33e0be
commit 47ab961
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/apps/user_ldap/lib/User_Proxy.php b/apps/user_ldap/lib/User_Proxy.php
@@ -253,7 +253,7 @@ public function setDisplayName($uid, $displayName) {
 	 * @return boolean either the user can or cannot
 	 */
 	public function canChangeAvatar($uid) {
-		return $this->handleRequest($uid, 'canChangeAvatar', array($uid));
+		return $this->handleRequest($uid, 'canChangeAvatar', [$uid], true);
 	}
 
 	/**

diff --git a/lib/private/Avatar/UserAvatar.php b/lib/private/Avatar/UserAvatar.php
@@ -97,7 +97,7 @@ public function set($data) {
 
 		$this->validateAvatar($img);
 
-		$this->remove();
+		$this->remove(true);
 		$type = $this->getAvatarImageType($img);
 		$file = $this->folder->newFile('avatar.' . $type);
 		$file->putContent($data);
@@ -193,7 +193,7 @@ private function validateAvatar(IImage $avatar) {
 	 * @throws \OCP\Files\NotPermittedException
 	 * @throws \OCP\PreConditionNotMetException
 	 */
-	public function remove() {
+	public function remove(bool $silent = false) {
 		$avatars = $this->folder->getDirectoryListing();
 
 		$this->config->setUserValue($this->user->getUID(), 'avatar', 'version',
@@ -203,7 +203,9 @@ public function remove() {
 			$avatar->delete();
 		}
 		$this->config->setUserValue($this->user->getUID(), 'avatar', 'generated', 'true');
-		$this->user->triggerChange('avatar', '');
+		if(!$silent) {
+			$this->user->triggerChange('avatar', '');
+		}
 	}
 
 	/**

diff --git a/tests/lib/Avatar/UserAvatarTest.php b/tests/lib/Avatar/UserAvatarTest.php
@@ -223,8 +223,7 @@ public function testSetAvatar() {
 		$this->config->expects($this->once())
 			->method('getUserValue');
 
-		// One on remove and once on setting the new avatar
-		$this->user->expects($this->exactly(2))->method('triggerChange');
+		$this->user->expects($this->exactly(1))->method('triggerChange');
 
 		$this->avatar->set($image->data());
 	}