Skip to content

Commit

Permalink
Fix mainfileinfodetailsview appending
Browse files Browse the repository at this point in the history
Since the jquery update to 3.5.0, it seems Handlebars doesn't correctly
render self-closed elements. This fixes mainfileinfodetailsview template
to not use self-closed elements and fixes the JS unit tests.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
  • Loading branch information
PVince81 authored and nextcloud-command committed Nov 19, 2021
1 parent ba8b55f commit 49e35ff
Show file tree
Hide file tree
Showing 12 changed files with 48 additions and 48 deletions.
16 changes: 8 additions & 8 deletions apps/files/js/dist/sidebar.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/files/js/dist/sidebar.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/files/js/templates.js
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ templates['mainfileinfodetailsview'] = template({"1":function(container,depth0,h
return undefined
};

return "<div class=\"thumbnailContainer\"><a href=\"#\" class=\"thumbnail action-default\"><div class=\"stretcher\"/></a></div>\n<div class=\"file-details-container\">\n <div class=\"fileName\">\n <h3 title=\""
return "<div class=\"thumbnailContainer\"><a href=\"#\" class=\"thumbnail action-default\"><div class=\"stretcher\"></div></a></div>\n<div class=\"file-details-container\">\n <div class=\"fileName\">\n <h3 title=\""
+ alias4(((helper = (helper = lookupProperty(helpers,"name") || (depth0 != null ? lookupProperty(depth0,"name") : depth0)) != null ? helper : alias2),(typeof helper === alias3 ? helper.call(alias1,{"name":"name","hash":{},"data":data,"loc":{"start":{"line":4,"column":13},"end":{"line":4,"column":21}}}) : helper)))
+ "\" class=\"ellipsis\">"
+ alias4(((helper = (helper = lookupProperty(helpers,"name") || (depth0 != null ? lookupProperty(depth0,"name") : depth0)) != null ? helper : alias2),(typeof helper === alias3 ? helper.call(alias1,{"name":"name","hash":{},"data":data,"loc":{"start":{"line":4,"column":40},"end":{"line":4,"column":48}}}) : helper)))
Expand Down
2 changes: 1 addition & 1 deletion apps/files/js/templates/mainfileinfodetailsview.handlebars
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="thumbnailContainer"><a href="#" class="thumbnail action-default"><div class="stretcher"/></a></div>
<div class="thumbnailContainer"><a href="#" class="thumbnail action-default"><div class="stretcher"></div></a></div>
<div class="file-details-container">
<div class="fileName">
<h3 title="{{name}}" class="ellipsis">{{name}}</h3>
Expand Down
18 changes: 9 additions & 9 deletions core/js/dist/files_client.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion core/js/dist/files_client.js.map

Large diffs are not rendered by default.

16 changes: 8 additions & 8 deletions core/js/dist/install.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion core/js/dist/install.js.map

Large diffs are not rendered by default.

16 changes: 8 additions & 8 deletions core/js/dist/login.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion core/js/dist/login.js.map

Large diffs are not rendered by default.

16 changes: 8 additions & 8 deletions core/js/dist/main.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion core/js/dist/main.js.map

Large diffs are not rendered by default.

0 comments on commit 49e35ff

Please sign in to comment.