Merge pull request #47638 from nextcloud/fix/share-attributes-null

fix: Properly handle share attributes if set to null
nextcloud · Aug 30, 2024 · 7362ede · 7362ede
2 parents 7b05c34 + d5ab2c5
commit 7362ede
Show file tree

Hide file tree

Showing 9 changed files with 18 additions and 9 deletions.
diff --git a/apps/files_sharing/src/views/SharingDetailsTab.vue b/apps/files_sharing/src/views/SharingDetailsTab.vue
@@ -423,13 +423,22 @@ export default {
 		 */
 		canDownload: {
 			get() {
-				return this.share.attributes.find(attr => attr.key === 'download')?.value || false
+				return this.share.attributes?.find(attr => attr.key === 'download')?.value ?? true
 			},
 			set(checked) {
 				// Find the 'download' attribute and update its value
-				const downloadAttr = this.share.attributes.find(attr => attr.key === 'download')
+				const downloadAttr = this.share.attributes?.find(attr => attr.key === 'download')
 				if (downloadAttr) {
 					downloadAttr.value = checked
+				} else {
+					if (this.share.attributes === null) {
+						this.$set(this.share, 'attributes', [])
+					}
+					this.share.attributes.push({
+						scope: 'permissions',
+						key: 'download',
+						value: checked,
+					})
 				}
 			},
 		},

diff --git a/dist/5643-5643.js.map b/dist/5643-5643.js.map
diff --git a/dist/5643-5643.js.map.license b/dist/5643-5643.js.map.license
diff --git a/dist/5643-5643.js → dist/8215-8215.js b/dist/5643-5643.js → dist/8215-8215.js
diff --git a/dist/5643-5643.js.license → dist/8215-8215.js.license b/dist/5643-5643.js.license → dist/8215-8215.js.license
diff --git a/dist/8215-8215.js.map b/dist/8215-8215.js.map
diff --git a/dist/8215-8215.js.map.license b/dist/8215-8215.js.map.license
@@ -0,0 +1 @@
+8215-8215.js.license
diff --git a/dist/files_sharing-files_sharing_tab.js b/dist/files_sharing-files_sharing_tab.js
diff --git a/dist/files_sharing-files_sharing_tab.js.map b/dist/files_sharing-files_sharing_tab.js.map