Fix whitespace and file action cleanup

Signed-off-by: Julius Härtl <jus@bitgrid.net>
nextcloud · Nov 20, 2018 · 78056a3 · 78056a3
1 parent fc99811
commit 78056a3
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 13 deletions.
diff --git a/apps/files/js/fileactions.js b/apps/files/js/fileactions.js
@@ -362,17 +362,16 @@
 			// remove previous
 			$tr.find('.action-menu').remove();
 
-			if (this.actions.length > 0) {
-				var $el = this._renderInlineAction({
-					name: 'menu',
-					displayName: '',
-					iconClass: 'icon-more',
-					altText: t('files', 'Actions'),
-					action: this._showMenuClosure
-				}, false, context);
-
-				$el.addClass('permanent');
-			}
+			var $el = this._renderInlineAction({
+				name: 'menu',
+				displayName: '',
+				iconClass: 'icon-more',
+				altText: t('files', 'Actions'),
+				action: this._showMenuClosure
+			}, false, context);
+
+			$el.addClass('permanent');
+
 		},
 
 		/**

diff --git a/apps/files_sharing/js/public.js b/apps/files_sharing/js/public.js
@@ -209,7 +209,7 @@ OCA.Sharing.PublicApp = {
 					// Remove the link. This means that files without a default action fail hard
 					$tr.find('a.name').attr('href', '#');
 
-					delete this.fileActions.actions.all.Download;
+					this.fileActions.actions.all = {};
 				}
 				return $tr;
 			};
@@ -299,6 +299,7 @@ OCA.Sharing.PublicApp = {
 
 			if (hideDownload === 'true') {
 				this.fileList.$el.find('#headerSelection').remove();
+				this.fileList.$el.find('.summary').find('td:first-child').remove();
 			}
 		}
 

diff --git a/core/js/tests/specs/sharedialoglinkshareview.js b/core/js/tests/specs/sharedialoglinkshareview.js
@@ -114,7 +114,7 @@ describe('OC.Share.ShareDialogLinkShareView', function () {
 
 			$hideDownloadCheckbox = view.$el.find('.hideDownloadCheckbox');
 
-			expect($hideDownloadCheckbox.length).toBeFalsy();
+			expect($hideDownloadCheckbox.length).toBeTruthy();
 		});
 
 		it('checkbox is checked when the setting is enabled', function () {