Remove filter_var flags due to PHP 7.3 deprecation, fixes #10894

Signed-off-by: Patrik Kernstock <info@pkern.at>
nextcloud · Sep 3, 2018 · 8f9fa9e · 8f9fa9e
1 parent a0a3450
commit 8f9fa9e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/apps/oauth2/lib/Controller/SettingsController.php b/apps/oauth2/lib/Controller/SettingsController.php
@@ -74,7 +74,7 @@ public function __construct(string $appName,
 	public function addClient(string $name,
 							  string $redirectUri): JSONResponse {
 
-		if (filter_var($redirectUri, FILTER_VALIDATE_URL, FILTER_FLAG_SCHEME_REQUIRED|FILTER_FLAG_HOST_REQUIRED) === false) {
+		if (filter_var($redirectUri, FILTER_VALIDATE_URL) === false) {
 			return new JSONResponse(['message' => $this->l->t('Your redirect URL needs to be a full URL for example: https://yourdomain.com/path')], Http::STATUS_BAD_REQUEST);
 		}
 

diff --git a/apps/theming/lib/ThemingDefaults.php b/apps/theming/lib/ThemingDefaults.php
@@ -174,9 +174,7 @@ public function getShortFooter() {
 		$legalLinks = ''; $divider = '';
 		foreach($links as $link) {
 			if($link['url'] !== ''
-				&& filter_var($link['url'], FILTER_VALIDATE_URL, [
-					'flags' => FILTER_FLAG_SCHEME_REQUIRED | FILTER_FLAG_HOST_REQUIRED
-				])
+				&& filter_var($link['url'], FILTER_VALIDATE_URL)
 			) {
 				$legalLinks .= $divider . '<a href="' . $link['url'] . '" class="legal" target="_blank"' .
 					' rel="noreferrer noopener">' . $link['text'] . '</a>';
@@ -339,7 +337,7 @@ public function replaceImagePath($app, $image) {
 		}
 		return false;
 	}
-	
+
 	/**
 	 * Increases the cache buster key
 	 */