Clear link to avoid downloads

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
nextcloud · Nov 20, 2018 · db87a7c · db87a7c
1 parent 6439368
commit db87a7c
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/apps/files_sharing/js/public.js b/apps/files_sharing/js/public.js
@@ -205,10 +205,10 @@ OCA.Sharing.PublicApp = {
 					var type = this.fileActions.getCurrentType();
 					var permissions = this.fileActions.getCurrentPermissions();
 					var action = this.fileActions.getDefault(mime, type, permissions);
-					if (action) {
-						// remove link href if there is a default action configured (disables downloading when trying to open in a new tab)
-						$tr.find('a.name').attr('href', '#');
-					}
+
+					// Remove the link. This means that files without a default action fail hard
+					$tr.find('a.name').attr('href', '#');
+
 					delete this.fileActions.actions.all.Download;
 				}
 				return $tr;