-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design review / polishing items for Nextcloud 14 (overview issue) #10094
Comments
cc @nextcloud/designers @nextcloud/javascript lots of small tasks to pick up in there also. Good for getting friends involved too. :) |
For #10094 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I cannot reproduce those. What browser did you use when testing?
Increasing the padding here will make the whole layout look a bit out of place in my opinion: @jancborchardt Having 44px height makes sense for the share options and the first checkbox to toggle the link share, but I would keep the small height for the link share options. I think an increased click target to 44px doesn't work well here, since you cannot clearly separate between the two lines. |
Right, also true. We should really put all these things in a proper popover like started in #7010, but I need help with that. ;)
Yes, the font issue I can not reproduce either, and others couldn’t either? Might be specific to @karlitschek’s setup? The move or copy buttons seem to only be broken in Safari, just tested with @MorrisJobke |
@jancborchardt @MorrisJobke @juliushaertl possible that the font loading issue is triggered by my ad blocker or something else. I will investigate. |
There are none - planned in the sidebar overview ticket: #10289 |
@jancborchardt Do you have any specific graphic in mind for that? |
@jancborchardt I don't like adding big images to the UI. I think they add to much visual distraction from the settings and don't provide any value regarding the content. We should keep it simple there and focus on providing a simple description and a link to possible extended documentation there. cc @nextcloud/designers |
We could add a padding to all checkboxes with their labels in the global input css, but I would suggest to do this for 15, since i would expect this might cause quite some bugs all over the places where the checkboxes are used. |
Hi team, |
@ykcab please open an issue for this so we can discuss it |
Should be all fixed now, besides those I moved to separate issues for further discussion:
|
Had a design review session of latest master with @karlitschek today, here are the results:
General
Font is not loading? Testing on Frank's laptop, only Helvetica showed, not Open SansFirst run wizard
Files
App management
User management
Settings
Still to discuss
The text was updated successfully, but these errors were encountered: