Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 primary storage only supports EC2 instance roles or env for dynamic access keys #24699

Closed
Imajie opened this issue Dec 14, 2020 · 0 comments · Fixed by #24685, #24700, #24765, #24852 or #24951
Closed

Comments

@Imajie
Copy link

Imajie commented Dec 14, 2020

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
It currently isn't possible to run Nextcloud in ECS and use the AWS task-role to provide access to S3. Currently leaving the access and secret keys blank will fall back to environment variables or EC2 instance role settings to obtain keys, see S3ConnectionTrait.php

Describe the solution you'd like
Rather than falling back to env and EC2 instance roles specifically, use the CredentialProvider::defaultProvider() which provides a sane, full list of possible fallbacks including ECS instance roles.

Describe alternatives you've considered
N/A

Additional context
N/A

@Imajie Imajie added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Dec 14, 2020
Imajie pushed a commit to Imajie/server that referenced this issue Dec 14, 2020
Imajie pushed a commit to Imajie/server that referenced this issue Dec 14, 2020
…S3 buckets

Signed-off-by: James Letendre <james.letendre@gmail.com>
@rullzer rullzer mentioned this issue Dec 15, 2020
59 tasks
@rullzer rullzer mentioned this issue Dec 18, 2020
39 tasks
This was referenced Dec 28, 2020
This was referenced Jan 11, 2021
@rullzer rullzer mentioned this issue Jan 21, 2021
19 tasks
@rullzer rullzer mentioned this issue Jan 29, 2021
@cuppett cuppett removed the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Jan 31, 2021
@cuppett cuppett reopened this Jan 31, 2021
rullzer added a commit that referenced this issue Feb 2, 2021
Resolves #24699, Support ES2 and ECS instance providers for S3 buckets
backportbot-nextcloud bot pushed a commit that referenced this issue Feb 2, 2021
Signed-off-by: James Letendre <james.letendre@gmail.com>
@rullzer rullzer mentioned this issue Feb 5, 2021
2 tasks
rullzer added a commit that referenced this issue Feb 5, 2021
[stable21] Resolves #24699, Support ES2 and ECS instance providers for S3 buckets
@rullzer rullzer mentioned this issue Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment