-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server is not publishing user properties to lookup-server #25290
Comments
Mind to sent a pull request? I would ignore the signature field for now. Hopefully one of the reviewer will know ;)
I guess we need to remove ['value'] here to make it work. |
Fix of the bug in the lookup_server_connector module to publish public user information to the lookup-server. As described in issue [nextcloud#25290](nextcloud#25290)
Fix of the bug in the lookup_server_connector module to publish public user information to the lookup-server. As described in issue [nextcloud#25290](nextcloud#25290) Signed-off-by: AbangTor <63029179+abangtor@users.noreply.github.com>
So... Digging on that topic, we can find the previous copy of that code, somewhere around there: 30051e7#diff-eb7b5fbd99fede3d2293d9e58f6e38f93f6e13d8240b304a72004665aec8d5ab Sounds like @kesselb is right, we should be able to just remove the Which leaves us with a couple And a couple
Though iAccountProperty and AccountManager won't mention signatures ... not sure I'm looking at the right place. I'll start with blank values for now. edit: and I'm too late ... nevermind then. |
Yes, I taught so too, that's why I added them as todo in the pull request. |
Nah. I made a bad suggestion ;)
|
Signed-off-by: Samuel MARTIN MORO <faust64@gmail.com>
Ok, changed my commit now to the example from @kesselb. |
Signed-off-by: Samuel MARTIN MORO <faust64@gmail.com> Signed-off-by: Samuel <faust64@gmail.com>
There is a bug in the getUserAccountData method in the RetryJob.php of the lookup-server-connector module.
The properties are written into an one dimensional array $publicData:
server/apps/lookup_server_connector/lib/BackgroundJobs/RetryJob.php
Line 197 in 7668c86
Later on the array is read as it is a two dimensional array:
server/apps/lookup_server_connector/lib/BackgroundJobs/RetryJob.php
Lines 203 to 214 in 7668c86
This causes the values to be empty and no properties are send to the loopup-server.
I don't know how to fix this exact, since I couldn't find a way to get the signature value from the Account or AccountProperty classes.
My current ugly fix is:
$publicData[$property->getName()]['value'] = $property->getValue();
The text was updated successfully, but these errors were encountered: