-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Accept/reject remote share action from "pending shares" view does not work #31301
Comments
I'm having a similar outcome, but my link appears to be correct. Not sure if this is the same issue, or indicating the issue is deeper than just the URL? |
I am experiencing exactly the same issue: Fresh install of NC 23.0.3 with PHP 8 - but also existing other instances (all NC 23.x) have that issue! I can also 1:1 confirm the FF devtools console outputs. |
Created a pull request, see above. To manually fix (if you have access), you need to edit the file |
That looks to have fixed it for me! thanks!! |
Fix accept/reject remote share action #31301
This is the fix for the described problem in #31301 Signed-off-by: MSe1969 <mse1969@posteo.de> Signed-off-by: szaimen <szaimen@e.mail.de>
This is the fix for the described problem in #31301 Signed-off-by: MSe1969 <mse1969@posteo.de> Signed-off-by: szaimen <szaimen@e.mail.de>
This is the fix for the described problem in #31301 Signed-off-by: MSe1969 <mse1969@posteo.de> Signed-off-by: szaimen <szaimen@e.mail.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
supposed to be fixed with #31910 |
Bug description
When I receive a folder remote share from a remote server (via federation sharing) and I go to the Shares > Pending shares, I can see the shared folder but when I click on "Accept share" or "Refuse share", there is an error message and nothing happens.
Error message : "Something happened. Unable to accept the share."
When clicking "Accept share", the Firefox devtools console returns the following (each time of a click):
XHR POST https://nuage.yaal.fr/ocs/v2.php/apps/files_sharing/api/v1/shares/pending/10 [[HTTP/2 404 Not Found 107ms]]
Note the "shares" part in the url (where I would expect "remote_shares" instead).
Steps to reproduce
Expected behavior
I'm expecting the action "Accept" or "Refuse" to be performed, with no error.
I suspect the url on which the POST action is done to be incorrect :
shouldnt https://nuage.yaal.fr/ocs/v2.php/apps/files_sharing/api/v1/shares/pending/10 be https://nuage.yaal.fr/ocs/v2.php/apps/files_sharing/api/v1/remote_shares/pending/10 instead? (Based on the documentation https://docs.nextcloud.com/server/latest/developer_manual/client_apis/OCS/ocs-share-api.html).
Installation method
Manual installation
Operating system
Debian/Ubuntu
PHP engine version
PHP 7.4
Web server
Nginx
Database engine version
PostgreSQL
Is this bug present after an update or on a fresh install?
Fresh Nextcloud Server install
Are you using the Nextcloud Server Encryption module?
Encryption is Disabled
What user-backends are you using?
Configuration report
List of activated Apps
Nextcloud Signing status
Nextcloud Logs
No response
Additional info
We are using OIDC user-backend with
oidc_login
plugin (see Configuration report)The text was updated successfully, but these errors were encountered: