-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jQuery.globalEval()={} - Problem with password strength and files_markdown #4067
Comments
LukasReschke
added a commit
to LukasReschke/strengthify
that referenced
this issue
Mar 26, 2017
We've overwritten jQuery.globalEval() for security reasons in Nextcloud, to make this now compatible again I've changed this code to manually call eval. Ref nextcloud/server#4067 Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Patch for jquery.strengthify.js: nextcloud/strengthify#14 |
cc @MorrisJobke |
LukasReschke
added a commit
that referenced
this issue
Mar 26, 2017
Fixes #4067 Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
LukasReschke
added a commit
that referenced
this issue
Mar 26, 2017
Fixes #4067 Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
And for the files_markdown app: #4068 |
MorrisJobke
pushed a commit
to nextcloud/strengthify
that referenced
this issue
Mar 26, 2017
* Use eval directly We've overwritten jQuery.globalEval() for security reasons in Nextcloud, to make this now compatible again I've changed this code to manually call eval. Ref nextcloud/server#4067 Signed-off-by: Lukas Reschke <lukas@statuscode.ch> * Increase version to 0.5.2 Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current master, personal settings, type a password into the "new password field"
Expected: Show password strength
Actual:
ReferenceError: zxcvbn is not defined
in jquery.strengthify.jsReason:
The script loading and executing of /core/vendor/zxcvbn/dist/zxcvbn.js at the bottom of /core/vendor/strengthify/jquery.strengthify.js is rendered dysfunctional by 148e7ab due to
in core/js/js.js which is needed by jQuery ajax()/getScript() to execute loaded script.
148e7ab also brakes files_markdown (see #3696 (comment))
The text was updated successfully, but these errors were encountered: