[Bug]: Sub folder shares were broken on ownership transfer

[luka-nextcloud]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

After an ownership transfer (via the web interface), sub shares can be broken and it's impossible to restore.

Steps to reproduce

• userA shares a folder D1 with userB
• userB creates and shares a subfolder D2 and shares it with userC
• userA revoke the share of D1 with userB
• userA transfers ownership of D1 to userD

After userD accepts the transfer:

• userC loses access to the folder D2
• if userD tries to share the folder D2 with userC : error message "Node for share not found, fileid: 132472"

Expected behavior

My suggestion for expected behavior:
Re-share should be deleted if restore failed to not block creating new share for the same user.

Installation method

Community Docker image

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

[solracsf]

Does occ sharing:delete-orphan-shares help here?
It does not fix the root cause of course.

[Gravelbones]

I have the same problem, but coming from a different scenario:

Steps to reproduce

userA shares a folder D1 with userB
userB creates a subfolder D2 and shares it with userC
userA transfers ownership of D1 to userD

After userD accepts the transfer:

userC loses access to the folder D2 (appears empty but visible)
userB can't see the sharing anymore
if userB tries to (re)share the folder D2 with userC : error message "Node for share not found, fileid: x

The problem is fixed by updating oc_table/uid_owner to the UID of userD.
Also userB is not present in oc_users table, due to being syncronized via LDAP, if that means something.