Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: No visual feedback for move operations #46645

Closed
4 of 8 tasks
kesselb opened this issue Jul 19, 2024 · 5 comments · Fixed by #47910
Closed
4 of 8 tasks

[Bug]: No visual feedback for move operations #46645

kesselb opened this issue Jul 19, 2024 · 5 comments · Fixed by #47910
Labels

Comments

@kesselb
Copy link
Contributor

kesselb commented Jul 19, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

Ther's no visual feedback for a move operation.

Steps to reproduce

  1. Add an external storage
  2. Have a large file (e.g. an ubuntu desktop iso)
  3. Move the large file from your home folder to the external storage
  4. There's no feedback that anything is happening

Nextcloud 28:

9664474.28.webm

Nextcloud 27:

9664474.27.webm

Expected behavior

Feedback that something is happening.

Installation method

None

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

I'm seeing a progress indicator with Nextcloud 30 again.

@kesselb kesselb added bug 1. to develop Accepted and waiting to be taken care of 28-feedback 29-feedback labels Jul 19, 2024
@kesselb
Copy link
Contributor Author

kesselb commented Jul 29, 2024

The loading animation is implemented, but does not work.

'files-list__row--loading': isLoading,

isLoading() {
return this.source.status === NodeStatus.LOADING
},

// Set loading state
Vue.set(node, 'status', NodeStatus.LOADING)

Screenshot from 2024-07-29 13-51-23

Screenshot from 2024-07-29 13-51-32

@susnux
Copy link
Contributor

susnux commented Aug 16, 2024

This is working now:

Bildschirmfoto_20240816_163402

@susnux susnux closed this as completed Aug 16, 2024
@kesselb
Copy link
Contributor Author

kesselb commented Aug 16, 2024

This is working now:

Also for 29 and 28?

@susnux
Copy link
Contributor

susnux commented Aug 16, 2024

Not working on 28. Really weird the status is updated but the update is not considered by Vues reactivity system...

@susnux susnux reopened this Aug 16, 2024
@kesselb
Copy link
Contributor Author

kesselb commented Aug 16, 2024

Really weird the status is updated but the update is not considered by Vues reactivity system...

Yep, I couldn't figure it out.
Let me know if you find the issue, I would really like to know it.

susnux added a commit that referenced this issue Sep 11, 2024
* Resolves: #46645

This adds loading toast notification while the move operation is running.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux added a commit that referenced this issue Sep 26, 2024
* Resolves: #46645

This adds loading toast notification while the move operation is running.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
backportbot bot pushed a commit that referenced this issue Sep 30, 2024
* Resolves: #46645

This adds loading toast notification while the move operation is running.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

[skip ci]
backportbot bot pushed a commit that referenced this issue Sep 30, 2024
* Resolves: #46645

This adds loading toast notification while the move operation is running.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

[skip ci]
backportbot bot pushed a commit that referenced this issue Sep 30, 2024
* Resolves: #46645

This adds loading toast notification while the move operation is running.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

[skip ci]
susnux added a commit that referenced this issue Oct 11, 2024
* Resolves: #46645

This adds loading toast notification while the move operation is running.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux added a commit that referenced this issue Oct 15, 2024
* Resolves: #46645

This adds loading toast notification while the move operation is running.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux added a commit that referenced this issue Oct 15, 2024
* Resolves: #46645

This adds loading toast notification while the move operation is running.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux added a commit that referenced this issue Oct 15, 2024
* Resolves: #46645

This adds loading toast notification while the move operation is running.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux added a commit that referenced this issue Oct 16, 2024
* Resolves: #46645

This adds loading toast notification while the move operation is running.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux added a commit that referenced this issue Oct 17, 2024
* Resolves: #46645

This adds loading toast notification while the move operation is running.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants