Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Show default expiration date on public share link creation #48860

Closed
4 of 8 tasks
sowjanyakch opened this issue Oct 23, 2024 · 1 comment · Fixed by #49115
Closed
4 of 8 tasks

[Bug]: Show default expiration date on public share link creation #48860

sowjanyakch opened this issue Oct 23, 2024 · 1 comment · Fixed by #49115
Assignees
Labels

Comments

@sowjanyakch
Copy link

sowjanyakch commented Oct 23, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

A default 7-day expiration is set for shares, but many users don’t notice it when creating shares. This leads to issues when shares expire, especially if the link was shared widely.

Steps to reproduce

  1. Create a public share link.
  2. Default expiration date is not shown in the share creation dialog.

Image

Expected behavior

Default expiration date should be shown in the share creation dialog.

Nextcloud Server version

28

Operating system

None

PHP engine version

PHP 8.2

Web server

None

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
"instanceid": "REMOVED SENSITIVE VALUE",
"passwordsalt": "REMOVED SENSITIVE VALUE",
"secret": "REMOVED SENSITIVE VALUE",
"trusted_domains": [
],
"datadirectory": "REMOVED SENSITIVE VALUE",
"overwrite.cli.url": "REMOVED SENSITIVE VALUE",
"dbtype": "mysql",
"version": "28.0.10.2",
"dbname": "REMOVED SENSITIVE VALUE",
"dbhost": "REMOVED SENSITIVE VALUE",
"dbtableprefix": "oc_",
"dbuser": "REMOVED SENSITIVE VALUE",
"dbpassword": "REMOVED SENSITIVE VALUE",
"logtimezone": "Europe/Berlin",
"loglevel": 2,
"log_authfailip": true,
"log_rotate_size": 104857600,
"installed": true,
"memcache.local": "\OC\Memcache\APCu",
"mail_smtpmode": "smtp",
"mail_from_address": "REMOVED SENSITIVE VALUE",
"mail_domain": "REMOVED SENSITIVE VALUE",
"mail_smtphost": "REMOVED SENSITIVE VALUE",
"mail_smtpport": "25",
"force_language": "de_DE",
"skeletondirectory": "",
"singleuser": false,
"maintenance": false,
"updatechecker": false,
"trashbin_retention_obligation": "30, 40",
"htaccess.RewriteBase": "/",
"memcache.locking": "\OC\Memcache\Redis",
"redis": {
"host": "REMOVED SENSITIVE VALUE",
"port": 0
},
"updater.release.channel": "enterprise",
"simpleSignUpLink.shown": false,
"sort_groups_by_name": true,
"mail_sendmailmode": "smtp",
"theme": "",
"defaultapp": "files",
"mysql.utf8mb4": true,
"default_phone_region": "DE",
"maintenance_window_start": 2,
"preview_max_memory": 256,
"profile.enabled": false,
"mail_template_class": "OCA\EmailTemplateTLRZ\EMailTemplate",
"default_language": "de_DE",
"memcache.distributed": "\OC\Memcache\Redis",
"htaccess.IgnoreFrontController": true,
"updater.server.url": "REMOVED SENSITIVE VALUE",
"trusted_proxies": "REMOVED SENSITIVE VALUE"
}

List of activated Apps

Enabled:

  • activity: 2.20.0
  • announcementcenter: 7.0.0
  • bruteforcesettings: 2.8.0
  • calendar: 4.7.16
  • circles: 28.0.0
  • cloud_federation_api: 1.11.0
  • collectives: 2.14.4
  • comments: 1.18.0
  • contacts: 5.5.3
  • contactsinteraction: 1.9.0
  • dashboard: 7.8.0
  • dav: 1.29.2
  • deck: 1.12.5
  • email_template_tlrz: 1.0.1
  • external: 5.3.1
  • federatedfilesharing: 1.18.0
  • federation: 1.18.0
  • files: 2.0.0
  • files_antivirus: 5.5.7
  • files_pdfviewer: 2.9.0
  • files_reminders: 1.1.0
  • files_sharing: 1.20.0
  • files_trashbin: 1.18.0
  • files_versions: 1.21.0
  • forms: 4.2.4
  • logreader: 2.13.0
  • lookup_server_connector: 1.16.0
  • nextcloud_announcements: 1.17.0
  • notifications: 2.16.0
  • oauth2: 1.16.4
  • password_policy: 1.18.0
  • photos: 2.4.0
  • provisioning_api: 1.18.0
  • recommendations: 2.0.0
  • related_resources: 1.3.0
  • richdocuments: 8.3.11
  • security_guard: 1.2.1
  • serverinfo: 1.18.0
  • settings: 1.10.1
  • sharebymail: 1.18.0
  • spreed: 18.0.11
  • support: 1.11.1
  • survey_client: 1.16.0
  • systemtags: 1.18.0
  • tasks: 0.16.1
  • text: 3.9.2
  • theming: 2.3.0
  • twofactor_backupcodes: 1.17.0
  • twofactor_totp: 10.0.0-beta.2
  • updatenotification: 1.18.0
  • user_status: 1.8.1
  • user_usage_report: 1.12.1
  • viewer: 2.2.0
  • weather_status: 1.8.0
  • workflowengine: 2.10.0

Disabled:

  • admin_audit: 1.18.0
  • encryption
  • files_confidential
  • files_external
  • files_lock
  • firstrunwizard: 1.1
  • globalsiteselector
  • privacy: 1.1.0
  • suspicious_login
  • user_ldap
  • user_saml

Nextcloud Signing status

  • SIP dialin is disabled
  • SIP dialout is disabled

Nextcloud Logs

No response

Additional info

No response

@sowjanyakch sowjanyakch added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Oct 23, 2024
@sowjanyakch sowjanyakch assigned sowjanyakch and nfebe and unassigned sowjanyakch Oct 23, 2024
@skjnldsv skjnldsv added enhancement and removed bug labels Oct 29, 2024
@skjnldsv
Copy link
Member

More of an enhancement I'd say.

nfebe added a commit that referenced this issue Nov 6, 2024
Prevent silent addition of expiration date to shares.

Resolves : #48860

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Nov 6, 2024
Prevent silent addition of expiration date to shares.

Resolves : #48860

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@joshtrichards joshtrichards added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 6, 2024
nfebe added a commit that referenced this issue Nov 7, 2024
Prevent silent addition of expiration date to shares.

Prevent silent addition for password to shares.

Both now have a `shareRequiresReview` check

Resolves : #48860

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Nov 7, 2024
Prevent silent addition of expiration date to shares.

Prevent silent addition for password to shares.

Both now have a `shareRequiresReview` check

Resolves : #48860

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe closed this as completed in 6d3f5d3 Nov 8, 2024
backportbot bot pushed a commit that referenced this issue Nov 8, 2024
Prevent silent addition of expiration date to shares.

Prevent silent addition for password to shares.

Both now have a `shareRequiresReview` check

Resolves : #48860

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

[skip ci]
backportbot bot pushed a commit that referenced this issue Nov 8, 2024
Prevent silent addition of expiration date to shares.

Prevent silent addition for password to shares.

Both now have a `shareRequiresReview` check

Resolves : #48860

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

[skip ci]
skjnldsv pushed a commit that referenced this issue Nov 8, 2024
Prevent silent addition of expiration date to shares.

Prevent silent addition for password to shares.

Both now have a `shareRequiresReview` check

Resolves : #48860

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Nov 8, 2024
Prevent silent addition of expiration date to shares.

Prevent silent addition for password to shares.

Both now have a `shareRequiresReview` check

Resolves : #48860

Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Nov 8, 2024
Prevent silent addition of expiration date to shares.

Prevent silent addition for password to shares.

Both now have a `shareRequiresReview` check

Resolves : #48860

Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Dec 9, 2024
Prevent silent addition of expiration date to shares.

Prevent silent addition for password to shares.

Both now have a `shareRequiresReview` check

Resolves : #48860

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Dec 9, 2024
Prevent silent addition of expiration date to shares.

Prevent silent addition for password to shares.

Both now have a `shareRequiresReview` check

Resolves : #48860

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants