-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Apple Provisioning profile #10068
Add Apple Provisioning profile #10068
Conversation
7089819
to
6a0a7cb
Compare
It seems that even with the most detailed provisioning profile iOS / macOS will still look for the .well-known/caldav / .well-known/carddav file :/ https://netfuture.ch/2013/07/dealing-with-apple-mobileconfig-configuration-profiles-quirks/ @MorrisJobke @rullzer Did we fix that issue that .well-known is only installed inside the Nextcloud-folder but not in the domains root? |
We did not, because it then needs to be configured in the Webserver itself |
So that can't be 100% fixed? 😭 |
We have a setup check for this nowadays. So I would assume that it will work for now and provide it. |
6a0a7cb
to
c689fd4
Compare
I rebased it. I would say, we should continue this and can improve in the future iteratively. |
@georgehrke Looks like this one will not make it in time, right? Would like to have it merged by tomorrow evening. |
Lets rebase and get this in. Yeah it won't work in 100% of the cases but so be it there is no way to do that. |
We should remove Will rebase, fix that and add tests next week. |
Could you have a look at this? So we can finally merge it :) |
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
c689fd4
to
16fec60
Compare
tl;dr of what changed:
|
please review @nextcloud/mac |
I can't test since.. well no mac... @georgehrke for a followup PR what would be nice
|
@marinofaggiana it would be great if you could implement downloading and opening this in the IOS client. That way users could more easily setup their stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side. And tests 🎉
But I can't tests since no macOS/iOS. so. 🐘
At end of next week I prepare a test for iOS cc @georgehrke |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works really nice 👍
fixes #1434
Todo: