Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon-black-white mixin to automatically generate icon classes #10311

Merged
merged 2 commits into from
Jul 20, 2018

Conversation

juliusknorr
Copy link
Member

This will fix #8702 by automatically generating proper classes for black and white icons.

@include icon-black-white('close', 'actions', $color-black, 1, true); will generate the following css:

.icon-close {
  background-image: var(--icon-close-000);
}
.icon-close-white, .icon-close.icon-white {
  background-image: var(--icon-close-fff);
}

The css vars are set with the correct URL as this was done in #9984

What do you think about that @skjnldsv @pixelipo @nextcloud/designers

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug design Design, UI, UX, etc. 2. developing Work in progress labels Jul 20, 2018
@juliusknorr juliusknorr requested review from pixelipo and skjnldsv July 20, 2018 10:58
@MorrisJobke
Copy link
Member

Works in IE11 fine 👍

@juliusknorr
Copy link
Member Author

Ok let me adjust it that way for the other icon classes as well 😉

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

Ready for review. I moved all icon classes that match the pattern, however there are some that don't so I kept them unchanged for now, so we don't break anything at this point. We should consider unifying this for 15 maybe, but I think we should announce that early, since we don't have any process for deprecating css classes.

I've tested this in Chrome, Firefox and IE11. Drop shadows are also kept on icons which use it, so the look is still the same for apps like talk that use the server icons.

@juliusknorr juliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 20, 2018
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and now icons work in IE11 for the gallery 👍

@MorrisJobke MorrisJobke merged commit 52ec71c into master Jul 20, 2018
@MorrisJobke MorrisJobke deleted the bugfix/8702/ie11-icon-white branch July 20, 2018 18:27
@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

icon-white class doesn't work on IE11
4 participants