Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of leftover-sorting-code from quickaccess-feature #9714 #9720 #10320

Merged
merged 2 commits into from
Aug 8, 2018

Conversation

newhinton
Copy link
Contributor

See #9714
See #9720
See #10176
See #10246

@newhinton
Copy link
Contributor Author

@skjnldsv Can you verify that i did not delete any routes or code that is important? There have been some changes, and i don't want to break stuff

@rullzer This one should be better, i'll just close #10246 now

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works still totally fine. 👍

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Jul 24, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Jul 24, 2018
@MorrisJobke MorrisJobke mentioned this pull request Jul 24, 2018
21 tasks
@newhinton
Copy link
Contributor Author

@skjnldsv Can you give me a little hint here? How do i fix the missing sign-off's for the older commits?

@rullzer
Copy link
Member

rullzer commented Jul 24, 2018

@newhinton you'd need to do a git rebase -i to edit the commits step by step. But I can sign them off for now :)

@rullzer rullzer force-pushed the feature/10176/Quick-Access-Cleanup branch from 5bb14f3 to fd61207 Compare July 24, 2018 18:04
@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 24, 2018
@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Jul 24, 2018
@MorrisJobke
Copy link
Member

JSUnit tests fail :/

@newhinton
Copy link
Contributor Author

I think i know why, but i'll need some time to fix it

@MorrisJobke MorrisJobke mentioned this pull request Jul 26, 2018
51 tasks
@skjnldsv
Copy link
Member

@newhinton any news? :)

@newhinton
Copy link
Contributor Author

@skjnldsv I am currently writing exams, and also the heat is very problematic at the moment. I will return developing early next week, though!

@skjnldsv
Copy link
Member

Okay, i'll see if I can help before your return! :)
If not, we'll wait for you! ;)

@rullzer rullzer mentioned this pull request Aug 2, 2018
58 tasks
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@skjnldsv skjnldsv force-pushed the feature/10176/Quick-Access-Cleanup branch from fd61207 to 7a78e0c Compare August 8, 2018 07:24
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv self-assigned this Aug 8, 2018
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Aug 8, 2018
@skjnldsv skjnldsv merged commit f8e9f86 into master Aug 8, 2018
@skjnldsv skjnldsv deleted the feature/10176/Quick-Access-Cleanup branch August 8, 2018 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants