-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check for empty string #10778
check for empty string #10778
Conversation
* this fixes a download error and an exception if the data content for encryption is empty * #3958: for recovering encrypted files with a damaged signature this is necessary in addition to turning the signature check off Signed-off-by: Stefan Weiberg <sweiberg@suse.com>
Makes sense not to try to decrypt an empty string, so for the pr as such 👍 but... |
@schiessle this is pointed out in the linked ticket #3958 If for some reason the signature of an encrypted file is corrupted and I switch the signature check off to bypass this check the download of the file won't finish as the last data block of the file is empty and Nextcloud throws an exception due to an empty string that can't be decrypted. |
Thanks for clarifying, @suntorytimed as soon as we have a second review this can be merged. I would also suggest to backport it. Can you prepare a second PR against the stable14 branch? Thanks! |
@schiessle done: #11783 |
[stable14] backport of #10778
Adding a check to see if keyFileContents is empty:
Signed-off-by: Stefan Weiberg sweiberg@suse.com