Check the permission of the underlying storage #11041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
approved these changes
Sep 4, 2018
nickvergessen
approved these changes
Sep 4, 2018
|
nickvergessen
added
2. developing
|
Ok so the reason it does boom is because of Which is the function called from the shared cache. This gives back the actual path instead of the jailed one. Making the getPermissions do 💥. @icewind1991 do we have to fixed the shared cache for this? |
rullzer
force-pushed
the
fix/noid/get_permission_of_storage_for_shares
branch
from
48957a7
to
74971a2
Compare
|
@icewind1991 please have a look if 74971a2 makes sense. It does to me but you know more about the internal dark magic of the storages. |
icewind1991
reviewed
Sep 6, 2018
apps/files_sharing/lib/Cache.php
Outdated
| @@ -169,4 +169,9 @@ private function getOwnerDisplayName() { | |||
| public function clear() { | |||
| // Not a valid action for Shared Cache | |||
| } | |||
|
|
|||
| public function getFolderContentsById($fileId) { | |||
There was a problem hiding this comment.
this shouldn't be needed as it's the same as the base method
There was a problem hiding this comment.
Hehe late night hacking ;)
rullzer
force-pushed
the
fix/noid/get_permission_of_storage_for_shares
branch
from
74971a2
to
b32b9db
Compare
rullzer
commented
Sep 6, 2018
|
It seems this makes other stuff do 💥. (yay for part files). |
Else shares might expose more permissions than the storage actually providers. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
isCreatable only works on folders isUpdatable if the file is not there but it is a part file also has to be checked on the folder Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Now that we actually check thepermissions properly we have to update the tests. * We checked an invalid path * We checked from wrong permissions (files never have CREATE permissions for example) Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
fix/noid/get_permission_of_storage_for_shares
branch
from
b32b9db
to
a2725c3
Compare
|
Ok all good now I think... @nickvergessen @icewind1991 please have yet another look. |
rullzer
added
3. to review
nickvergessen
approved these changes
Sep 13, 2018
|
@icewind1991 your +1 still counts? |
|
👍 |
nickvergessen
deleted the
fix/noid/get_permission_of_storage_for_shares
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Else shares might expose more permissions than the storage actually
providers.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl