Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config and babel for ie11 #11135

Merged
merged 3 commits into from
Sep 26, 2018
Merged

Update config and babel for ie11 #11135

merged 3 commits into from
Sep 26, 2018

Conversation

skjnldsv
Copy link
Member

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
},
"modules": false,
"blacklist": ["useStrict"],
"useBuiltIns": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those two not anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they were not needed :)

@nickvergessen
Copy link
Member

Same should happen to all the apps in apps/ too I guess?

@skjnldsv
Copy link
Member Author

Same should happen to all the apps in apps/ too I guess?

@nickvergessen Yes :)

@nickvergessen
Copy link
Member

@skjnldsv 14.0.1 backport? or 14.0.2?

@skjnldsv
Copy link
Member Author

@nickvergessen both are fine, :)

@rullzer
Copy link
Member

rullzer commented Sep 26, 2018

conflicts

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure fine by me

@rullzer rullzer merged commit bf57c53 into master Sep 26, 2018
@rullzer rullzer deleted the babel-npm-webpack-fixes branch September 26, 2018 19:34
@MorrisJobke
Copy link
Member

@skjnldsv Mind to do the backport to stable14?

@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 1, 2018

Backport in #11490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants