Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid inline input confirm border #11423

Merged
merged 2 commits into from
Sep 28, 2018
Merged

Fix invalid inline input confirm border #11423

merged 2 commits into from
Sep 28, 2018

Conversation

skjnldsv
Copy link
Member

before After
capture d ecran_2018-09-27_22-01-30 capture d ecran_2018-09-27_22-02-06

@nextcloud/designers

@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews backport-request labels Sep 27, 2018
@skjnldsv skjnldsv added this to the Nextcloud 15 milestone Sep 27, 2018
@skjnldsv skjnldsv self-assigned this Sep 27, 2018
@skjnldsv
Fix invalid inline input confirm border
e744b02 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
TABS :D
4bfe88d 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
danxuliu
danxuliu approved these changes Sep 28, 2018
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested (with an ad hoc form, not with the Contacts app as shown in the screenshot) and works 👍

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 28, 2018
@skjnldsv
Copy link
Member Author

sh: 1: kill: No such process
Unrelated

@skjnldsv skjnldsv mentioned this pull request Sep 28, 2018
Merged
@MorrisJobke MorrisJobke merged commit f6e39e5 into master Sep 28, 2018
@MorrisJobke MorrisJobke deleted the inline-input-error-fix branch September 28, 2018 08:59
@jancborchardt
Copy link
Member

screenshot from 2018-10-03 16-24-51
🤔 😉

@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 3, 2018

@jancborchardt 😂😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@danxuliu danxuliu danxuliu approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.
5 participants
@skjnldsv @jancborchardt @rullzer @danxuliu @MorrisJobke