Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable14] Fix share header text on small widths #11511

Merged
merged 2 commits into from
Oct 1, 2018
Merged

[stable14] Fix share header text on small widths #11511

merged 2 commits into from
Oct 1, 2018

Conversation

jancborchardt
Copy link
Member

Backport of #11502

@jancborchardt
Ellipsize long filenames and sharee names in public share page header
1b92ec0 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt
Remove non-clickable right margin from 3-dot-menu in share page header
687d050 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt jancborchardt added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: sharing labels Oct 1, 2018
@jancborchardt jancborchardt added this to the Nextcloud 14.0.2 milestone Oct 1, 2018
@jancborchardt jancborchardt mentioned this pull request Oct 1, 2018
Merged
MorrisJobke
MorrisJobke approved these changes Oct 1, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 1, 2018
@rullzer rullzer merged commit e7cdacf into stable14 Oct 1, 2018
@rullzer rullzer deleted the stable14-share-header branch October 1, 2018 15:36
@MorrisJobke MorrisJobke mentioned this pull request Oct 3, 2018
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Nov 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: sharing
Projects
None yet
Milestone
Nextcloud 14.0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@jancborchardt @MorrisJobke @skjnldsv @rullzer