Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force multiselect max-height to 5.5 items #11571

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Force multiselect max-height to 5.5 items #11571

merged 1 commit into from
Oct 3, 2018

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 3, 2018

@nextcloud/designers
capture d ecran_2018-10-03_08-32-50
Fix #11543

@skjnldsv
Force multiselect max-height to 5.5 items
66664cf 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews backport-request labels Oct 3, 2018
@skjnldsv skjnldsv added this to the Nextcloud 15 milestone Oct 3, 2018
@skjnldsv skjnldsv self-assigned this Oct 3, 2018
MorrisJobke
MorrisJobke approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
Copy link
Member

@skjnldsv Could you create a backport PR for 14?

jancborchardt
jancborchardt approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, yay for half entries 👍

@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 3, 2018
@rullzer rullzer merged commit ae71a55 into master Oct 3, 2018
@rullzer rullzer deleted the dropdown-bottom-users-list-fix branch October 3, 2018 10:04
@skjnldsv skjnldsv mentioned this pull request Oct 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: users and groups
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @MorrisJobke @jancborchardt @rullzer