Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled ldap fix #12306

Merged
merged 2 commits into from
Nov 6, 2018
Merged

Disabled ldap fix #12306

merged 2 commits into from
Nov 6, 2018

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 6, 2018

Fix #11629

@skjnldsv skjnldsv added this to the Nextcloud 15 milestone Nov 6, 2018
@skjnldsv skjnldsv self-assigned this Nov 6, 2018
rullzer
rullzer approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 🚀

@skjnldsv
Show disabled even if empty if ldap enabled
9f532df 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Build
7260d22 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@MorrisJobke MorrisJobke mentioned this pull request Nov 6, 2018
Merged
29 tasks
MorrisJobke
MorrisJobke approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit c92d35a into master Nov 6, 2018
@MorrisJobke MorrisJobke deleted the disabled-ldap-fix branch November 6, 2018 15:12
@rullzer rullzer mentioned this pull request Nov 7, 2018
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Nov 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug feature: ldap feature: users and groups
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @rullzer @MorrisJobke