Also use default label if share label is null #12332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
added
bug
3. to review
juliusknorr
requested review from
MorrisJobke,
jancborchardt,
ChristophWurst and
skjnldsv
skjnldsv
approved these changes
Nov 7, 2018
ChristophWurst
approved these changes
Nov 7, 2018
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/12314/existing-link-title
branch
from
837bca3 to
d110f0c
Compare
MorrisJobke
added
4. to release
|
codecov failures :/ |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a share link was there before the multiple share link pr was merged, the label was null and therefore nothing was rendered in the UI.
Fixes #12314