-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove conflicting multiselect #12468
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Should this be in 15? Or better wait for 16? |
@MorrisJobke ideally 15. But if this is too complicated, i'll add a stricter css rule to backport it to 15 and make sure we ignore this conflict :) |
I was able to complete the full setup and use the multiselect without any issues. The multiselect in core have nothing to do with the multiselect used in the ldap config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked with rg multiselect -g \!3rdparty -t js -M 150
and couldn't find any occurences of a multiselect apart from the Vue one.
👍 (50% 🐘)
I'm unsure if we should do this that late in the cycle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works 👍
I would like to get some feedback from @juliushaertl @rullzer and @nickvergessen about this. |
It seems to work. Let's do it to avoid weird patches. |
See #1831
@blizzz can you check the ldap please?
It should be using the other jQuery ui multiselect, this is the last location I could find where it was being used :)
@nextcloud/designers