Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy activity stuff #13798

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Remove legacy activity stuff #13798

merged 1 commit into from
Jan 28, 2019

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 24, 2019 •
edited
Loading

Ref nextcloud/activity#342

Removing a lot of code that was used to wrap old activity extensions which have been replaced by proper interfaces in Nextcloud 11.

Also the code that was used back then to add activities was removed in #11636 , so the apps need to be updated anyway.

To copy to C24DA2

Removed from public namespace:

* `OCP\Activity\IManager::getNotificationTypes` #13798
* `OCP\Activity\IManager::getDefaultTypes` #13798
* `OCP\Activity\IManager::getTypeIcon` #13798
* `OCP\Activity\IManager::translate` #13798
* `OCP\Activity\IManager::getSpecialParameterList` #13798
* `OCP\Activity\IManager::getGroupParameter` #13798
* `OCP\Activity\IManager::getNavigation` #13798
* `OCP\Activity\IManager::isFilterValid` #13798
* `OCP\Activity\IManager::filterNotificationTypes` #13798
* `OCP\Activity\IManager::getQueryForFilter` #13798

@nickvergessen
Remove legacy activity stuff
abd305e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 16 milestone Jan 24, 2019
rullzer
rullzer approved these changes Jan 24, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHOOHOO

ChristophWurst
ChristophWurst approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 28, 2019
@MorrisJobke MorrisJobke merged commit f746d36 into master Jan 28, 2019
@MorrisJobke MorrisJobke deleted the remove-legacy-activity-stuff branch January 28, 2019 10:17
@rullzer rullzer mentioned this pull request Jan 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer rullzer approved these changes

@schiessle schiessle Awaiting requested review from schiessle

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: activity and notification technical debt
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @rullzer @ChristophWurst @MorrisJobke