dav: Fix handling of chunked WebDAV upload #13871
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When $data is null (which can happen when $request->getBodyAsStream() returns null), the Exceptions says "copied bytes: 0, expected filesize: 0", which sounds more like success...
Just to summarize: this can be triggered by uploading an empty file? |
MorrisJobke
requested review from
icewind1991,
nickvergessen,
rullzer and
ChristophWurst
|
@MorrisJobke No. The PDF uploaded by the scanner definitely isn't empty, and on the other hand uploading an empty TXT via gvfs didn't trigger the bug. I guess the scanner just starts with an empty body in the first request of a chunked transfer. |
ariselseng
approved these changes
Mar 4, 2019
@MorrisJobke You are right. I triggered this bug by syncing an empty file with the desktop client. |
Status of 15220: failure
Show full log |
|
Failure is unrelated. |
|
/backport to stable15 |
|
backport to stable15 in #14517 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
$datais null (which can happen when$request->getBodyAsStream()returnsnull), the Exceptions says "copied bytes: 0, expected filesize: 0", which sounds more like success... So treat it as such!This regression (it worked in Nextcloud 14) was probably introduced by commit 93de637
The setup resulting in this situation was a Canon iR-ADV C5030 uploading its scans via WebDAV to an SFTP external storage. Here is the error that resulted in an HTTP Error 500 being returned:
Nextcloud log (data/nextcloud.log)
Nextcloud log
{ "reqId": "AQ84OEsk9APcLfSPb4tu", "level": 4, "time": "2019-01-28T12:36:20+00:00", "remoteAddr": "<redacted>", "user": "<redacted>", "app": "webdav", "method": "PUT", "url": "/remote.php/webdav/<redacted>", "message": { "Exception": "Sabre\\DAV\\Exception", "Message": "Error while copying file to target location (copied bytes: 0, expected filesize: 0 )", "Code": 0, "Trace": [ { "file": "/var/www/vhosts/<redacted>/httpdocs/apps/dav/lib/Connector/Sabre/Directory.php", "line": 156, "function": "put", "class": "OCA\\DAV\\Connector\\Sabre\\File", "type": "->", "args": [ null ] }, { "file": "/var/www/vhosts/<redacted>/httpdocs/3rdparty/sabre/dav/lib/DAV/Server.php", "line": 1096, "function": "createFile", "class": "OCA\\DAV\\Connector\\Sabre\\Directory", "type": "->", "args": [ "20190128125733.pdf", null ] }, { "file": "/var/www/vhosts/<redacted>/httpdocs/3rdparty/sabre/dav/lib/DAV/CorePlugin.php", "line": 525, "function": "createFile", "class": "Sabre\\DAV\\Server", "type": "->", "args": [ "NAS/20190128125733.pdf", null, null ] }, { "function": "httpPut", "class": "Sabre\\DAV\\CorePlugin", "type": "->", "args": [ { "absoluteUrl": "https://<redacted>:443/remote.php/webdav/<redacted>", "__class__": "Sabre\\HTTP\\Request" }, { "__class__": "Sabre\\HTTP\\Response" } ] }, { "file": "/var/www/vhosts/<redacted>/httpdocs/3rdparty/sabre/event/lib/EventEmitterTrait.php", "line": 105, "function": "call_user_func_array", "args": [ [ { "__class__": "Sabre\\DAV\\CorePlugin" }, "httpPut" ], [ { "absoluteUrl": "https://<redacted>:443/remote.php/webdav/<redacted>", "__class__": "Sabre\\HTTP\\Request" }, { "__class__": "Sabre\\HTTP\\Response" } ] ] }, { "file": "/var/www/vhosts/<redacted>/httpdocs/3rdparty/sabre/dav/lib/DAV/Server.php", "line": 479, "function": "emit", "class": "Sabre\\Event\\EventEmitter", "type": "->", "args": [ "method:PUT", [ { "absoluteUrl": "https://<redacted>:443/remote.php/webdav/<redacted>", "__class__": "Sabre\\HTTP\\Request" }, { "__class__": "Sabre\\HTTP\\Response" } ] ] }, { "file": "/var/www/vhosts/<redacted>/httpdocs/3rdparty/sabre/dav/lib/DAV/Server.php", "line": 254, "function": "invokeMethod", "class": "Sabre\\DAV\\Server", "type": "->", "args": [ { "absoluteUrl": "https://<redacted>:443/remote.php/webdav/<redacted>", "__class__": "Sabre\\HTTP\\Request" }, { "__class__": "Sabre\\HTTP\\Response" } ] }, { "file": "/var/www/vhosts/<redacted>/httpdocs/apps/dav/appinfo/v1/webdav.php", "line": 80, "function": "exec", "class": "Sabre\\DAV\\Server", "type": "->", "args": [] }, { "file": "/var/www/vhosts/<redacted>/httpdocs/remote.php", "line": 163, "args": [ "/var/www/vhosts/<redacted>/httpdocs/apps/dav/appinfo/v1/webdav.php" ], "function": "require_once" } ], "File": "/var/www/vhosts/<redacted>/httpdocs/apps/dav/lib/Connector/Sabre/File.php", "Line": 191, "CustomMessage": "--" }, "userAgent": "UniversalSend_WebDAV/1.0", "version": "15.0.2.0" }