Add min-version/max-version to fulltextsearch provider element #14905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
rullzer,
MorrisJobke,
ArtificialOwl and
ChristophWurst
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@daita Done. Just for reference the attributes are checked in the full text search app to see if a provider should be loaded for a specific Nextcloud version: https://github.com/nextcloud/fulltextsearch/pull/463/files |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/noid/add-fulltextsearch-min-version
branch
from
098704a to
7aba080
Compare
juliusknorr
changed the title
3 tasks
juliusknorr
added
3. to review
ArtificialOwl
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@daita In #14302 (comment) you mentioned a version parameter but in deck you actually used min-version. Can you clarify what is actually used, since I couldn't find where this is checked.