Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove recommendation for opcache on CLI #15468

Merged
merged 1 commit into from
May 9, 2019
Merged

Remove recommendation for opcache on CLI #15468

merged 1 commit into from
May 9, 2019

Conversation

MorrisJobke
Copy link
Member

@MorrisJobke
Remove recommendation for opcache on CLI
c8f2198 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label May 9, 2019
@MorrisJobke MorrisJobke added this to the Nextcloud 17 milestone May 9, 2019
@MorrisJobke MorrisJobke mentioned this pull request May 9, 2019
Closed
@MorrisJobke
Copy link
Member Author

/backport to stable16

@MorrisJobke
Copy link
Member Author

/backport to stable15

@MorrisJobke
Copy link
Member Author

/backport to stable14

blizzz
blizzz approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 9, 2019
@MorrisJobke MorrisJobke merged commit 38efad7 into master May 9, 2019
@MorrisJobke MorrisJobke deleted the fix/noid/remove-recommendation-for-cli-opcache branch May 9, 2019 11:47
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 9, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable16 in #15471

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 9, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable15 in #15472

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 9, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable14 in #15473

@kesselb
Copy link
Contributor

kesselb commented May 9, 2019

Fixes #10810 as well ;)

@Kranzes Kranzes mentioned this pull request Mar 14, 2024
Merged
13 tasks
Kranzes added a commit to Kranzes/nixpkgs that referenced this pull request Mar 14, 2024
@Kranzes
nixos/nextcloud: remove opcache.enable_cli=1
9353fb2 
Upstream no longer recommends enabling the opcache cli.
See the following:
 - nextcloud/documentation#1439
 - nextcloud/server#15468
github-actions bot pushed a commit to NixOS/nixpkgs that referenced this pull request Mar 14, 2024
@Kranzes @github-actions
nixos/nextcloud: remove opcache.enable_cli=1
bd351f8 
Upstream no longer recommends enabling the opcache cli.
See the following:
 - nextcloud/documentation#1439
 - nextcloud/server#15468

(cherry picked from commit 9353fb2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@blizzz blizzz blizzz approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 17
Development

Successfully merging this pull request may close these issues.

OPcache recommendation wrong (opcache.enable_cli=1)
4 participants
@MorrisJobke @kesselb @blizzz @skjnldsv