-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fetching additional search results on scrolling down #15557
Fix fetching additional search results on scrolling down #15557
Conversation
/backport to stable16 |
Related? #15260 |
Seems to be a different issue from my point of view. Additionally, while my fix does work on a desktop browser, it does not work on my mobile browser. I'll try to figure out that as well. |
902b6f1
to
bc2377f
Compare
It's now fixed for mobile browsers as well. |
Will this fix grid view not scrolling to load in additional photos? #16510? |
No, unfortunately, it does not. |
@rbuehlma please rebase on latest master :) |
bc2377f
to
f0391e1
Compare
Rebase done but not tested after rebase. |
Master is no 18 development. If this needs to go into 17 please follow the normal backport procedures after merging. |
Signed-off-by: René Bühlmann <rene@buehlmann.net>
f0391e1
to
675d6f7
Compare
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
backport to stable16 in #17304 |
/backport to stable17 |
backport to stable17 in #17305 |
When searching for files, the first 30 results are listed. Currently it is not possible to fetch additional results. The code to fetch more results when scrolling down is already there but it seems the scrolling container has changed.
This fix re-enables this feature.
This also fixes #15088
Tested on Firefox and Nextcloud 16.0.0.