+nodeinfo public service

[ArtificialOwl]

needed by the social app.

NodeInfo is an effort to create a standardized way of exposing metadata about a server running one of the distributed social networks. The two key goals are being able to get better insights into the user base of distributed social networking and the ability to build tools that allow users to choose the best fitting software and server for their needs.

source: https://github.com/jhass/nodeinfo

[ArtificialOwl]

/backport to stable16

[ArtificialOwl]

/backport to stable15

[MorrisJobke]

@daita Mind to add a setup check as well and add it to the Nginx config in the docs? The setup check should only run if the social app is enabled.

[MorrisJobke]

@daita Mind to add a setup check as well and add it to the Nginx config in the docs? The setup check should only run if the social app is enabled.

🏓

[ArtificialOwl]

So, there is some check. Also, this should fix #13088.

I think more logical to returns 404 if the public_service is not set, or if the app is not available/installed (instead of 501)

[rullzer]

So is this ready?

[ArtificialOwl]

My bad, totally forgot to push.

However, we also need to define what error code should be returned:

• when no public service as been assigned.
• when public service as been assigned, the app is still enabled but the linked php file is not readable.
• when public service as been assigned but the app is not enabled anymore.

Also: #13088 (comment)

@MorrisJobke 🏓

[ArtificialOwl]

@rullzer can you have a look to my last post regarding this issue?

[rullzer]

• when no public service as been assigned.
• when public service as been assigned, the app is still enabled but the linked php file is not readable.
• when public service as been assigned but the app is not enabled anymore.

in all those cases a 404 seems appropriate. And do proper logging to the log file.
For the end user it is all a not found error basically.

[ArtificialOwl]

#16919 - so I checked the current implementation, and confirm that this PR:

• change the public.php to fit the last comment from @rullzer (returning 404 for each described cases) (should fix [ Nextcloud 15 ] : Social app missing trigger error about /.well-known/webfinger #13088)
• add .well-known/nodeinfo public service
• add tests

also rebased.

@nickvergessen @ChristophWurst @danxuliu please review before next beta/rc

[nickvergessen]

So the social app is going to set that config?

[ArtificialOwl]

like the webfinger public service, yes

[backportbot-nextcloud]

The backport to stable16 failed. Please do this backport manually.

[backportbot-nextcloud]

The backport to stable15 failed. Please do this backport manually.

[ArtificialOwl]

@rullzer i'll make a light backport of the fix on the tests