Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/calendar/delegation #16666

Merged
merged 5 commits into from
Aug 15, 2019
Merged

Feature/calendar/delegation #16666

merged 5 commits into from
Aug 15, 2019

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Aug 6, 2019 •
edited by georgehrke
Loading

fixes #7085

@rullzer rullzer added this to the Nextcloud 17 milestone Aug 6, 2019
@rullzer rullzer requested a review from georgehrke August 6, 2019 11:48
georgehrke
georgehrke requested changes Aug 6, 2019
View reviewed changes
Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First quick dirty review, will check in depth later

apps/dav/lib/CalDAV/Proxy/Proxy.php Show resolved Hide resolved
apps/dav/lib/Migration/Version1011Date20190806104428.php Show resolved Hide resolved
@MorrisJobke MorrisJobke mentioned this pull request Aug 8, 2019
Merged
28 tasks
@tcitworld
Copy link
Member

Could you explain what's the motive behind this?

@georgehrke
Copy link
Member

Could you explain what's the motive behind this?

This will allow you to delegate all your calendars to someone else. Most common use-case is someone sharing their calendars with their assistant/secretary to allow them to send out and respond to invitations on their behalf.

@tcitworld
Copy link
Member

Thanks, wasn't sure if it was the issue that you linked on top.

rullzer added 2 commits August 14, 2019 09:42
@rullzer @georgehrke
Add table to handle calendar delegations
5f3d0a6 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer @georgehrke
Add DB mapper and Entity
22f29d8 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@georgehrke georgehrke force-pushed the feature/calendar/delegation branch from 97e792b to 168507b Compare August 14, 2019 11:43
@georgehrke georgehrke force-pushed the feature/calendar/delegation branch 3 times, most recently from c114528 to 39bdeb4 Compare August 14, 2019 12:14
@georgehrke
Copy link
Member

61A4B590-7041-4254-9A12-47DCD40AC5CC-2

🎉🎉🎉

@georgehrke
Copy link
Member

georgehrke commented Aug 14, 2019 •
edited
Loading

tldr of what's left:

  • add ProxyMapper to Resource and Room principal backends
  • tests

@georgehrke
Copy link
Member

Let's see if Drone is happy now.

@georgehrke georgehrke force-pushed the feature/calendar/delegation branch from e47e293 to 7179b22 Compare August 15, 2019 13:36
rullzer and others added 3 commits August 15, 2019 15:41
@rullzer @georgehrke
Use the proxymapper to obtain valid proxy data
01a4644 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer @georgehrke
Early first stage implementation of the groupset
3d86537 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@georgehrke
use principaluri instead of userid, allowing to add delegates for roo…
63d584a 
…ms and things

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

!fixup add owner_id and proxy_id as db index, since we use it for querying

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

!fixup don't add ACL for each individual proxy, just use calendar-proxy groups

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

!fixup allow delegation of resources / rooms

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

!fixup fix addIndex call in migration

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

!fixup fix remaining constructor calls of Principal

Signed-off-by: Georg Ehrke <developer@georgehrke.com>

!fixup minor fixes and unit tests

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the feature/calendar/delegation branch from 7179b22 to 63d584a Compare August 15, 2019 13:43
@georgehrke georgehrke requested review from georgehrke and removed request for georgehrke August 15, 2019 13:43
@rullzer rullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 15, 2019
@rullzer
Copy link
Member Author

rullzer commented Aug 15, 2019

Lets merge this!

@rullzer rullzer merged commit f452e23 into master Aug 15, 2019
@rullzer rullzer deleted the feature/calendar/delegation branch August 15, 2019 17:30
@rlx-unlimited
Copy link

pretty excited about this feature, has this been released already (nextcloud 18 is not showing any delegates in ical)? how can this be activated?

@tcitworld
Copy link
Member

@alex-s-team It's available in Nextcloud 17. It will work with CalDAV clients that support the feature, such as Apple Calendar or BusyCal.

@rlx-unlimited
Copy link

thanks very much for your answer, we are using apple calendar and there are no delegates showing up. do i have to activate the feature somehow via config or is the principal url different?

@tcitworld
Copy link
Member

As this seems to be a setup issue I would like to ask you to raise your question in the forums (so that we don't spam people in this issue): https://help.nextcloud.com

If you wish support with setup issues from Nextcloud GmbH they offer this as part of the Nextcloud subscription. Learn more about this at https://nextcloud.com/enterprise/

@tcitworld tcitworld mentioned this pull request Nov 18, 2020
Open
@tcitworld tcitworld mentioned this pull request Feb 15, 2021
Closed
@rotdrop rotdrop mentioned this pull request Jan 31, 2023
Closed
@rotdrop
Copy link
Contributor

rotdrop commented Feb 21, 2023

Just for the record: here we find that this does not work with the OSX calendar app: #17053. At least it is not possible to find anyone to delegate the calendar to ...

@z3ky
Copy link

z3ky commented Dec 16, 2023 •
edited
Loading

@rotdrop Maybe the caldav trashbin #26083 #1662 has broken delegation #42051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehrke georgehrke georgehrke requested changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement feature: dav
Projects
None yet
Milestone
Nextcloud 17
Development

Successfully merging this pull request may close these issues.

Calendar delegation
6 participants
@rullzer @tcitworld @georgehrke @rlx-unlimited @rotdrop @z3ky