Allow admin configured mounts to use user configured global credentials #16790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
reviewed
Aug 19, 2019
icewind1991
force-pushed
the
admin-use-user-global-auth
branch
from
ce7009b to
06057c7
Compare
wiswedel
reviewed
Aug 22, 2019
wiswedel
requested changes
Aug 22, 2019
|
@icewind1991 any feedback to my change requests? Just wanna make sure this goes into 17. |
|
@wiswedel he was on on holiday ;) |
Unbelievable |
|
Master is no 18 development. If this needs to go into 17 please follow the normal backport procedures after merging. |
Ah, an auto-reference by a comment in the 17 beta PR made me assume this was actually supposed to be part of that PR. |
|
/backport to stable17 |
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
admin-use-user-global-auth
branch
from
06057c7 to
eccf4dc
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
admin-use-user-global-auth
branch
from
eccf4dc to
6036553
Compare
|
You can now configure the credentials as with "user provided" |
ChristophWurst
approved these changes
Sep 10, 2019
|
backport to stable17 in #17090 |
|
Thanks a lot, @icewind1991 @rullzer @ChristophWurst @kesselb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when there are multiple admin configured mounts that should all use the same user configured credentials
Fixes #2861