allow using the same user-provided credentials for multiple storages #16791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
kesselb
reviewed
Aug 19, 2019
|
Master is no 18 development. If this needs to go into 17 please follow the normal backport procedures after merging. |
|
@icewind1991 conflicts. Do we want this in 18? |
|
@icewind1991 please reopen if it is still relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All "user provided credentials" storages with the same credential identifier will use the same set of credentials.
This is useful for having multiple admin configured storages use the same set of user provided credentials
Also adds an option to set tooltips for external storage parameters and removes some deprecated code